The iPhone X's screen still has all the important stuff to make iOS, apps, and content look great, like HDR, TrueTone, and a wide color gamut. Both the iPhone X and iPhone 11 Pro even have the same sharpness at 458 pixels-per-inch.
The iPhone 11 Pro's screen has better contrast ratio and brightness. If you ever complained about your iPhone X's contrast ratio or brightness, then you could add it to your list of "pros" to upgrade, but it shouldn't be the only reason why.